Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34075 )
Change subject: arch, include, soc: Use common stdint.h
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34075/4/src/arch/arm/armv7/mmu.c
File src/arch/arm/armv7/mmu.c:
https://review.coreboot.org/c/coreboot/+/34075/4/src/arch/arm/armv7/mmu.c@16...
PS4, Line 168: printk(BIOS_DEBUG, "Creating new subtable @%p for [%#.8" PRIxPTR ":%#.8" PRIxPTR ")\n",
This is an architecture file, so we know what the underlying type is (even if it wasn't the same for […]
Done
https://review.coreboot.org/c/coreboot/+/34075/4/src/soc/nvidia/tegra210/mmu...
File src/soc/nvidia/tegra210/mmu_operations.c:
https://review.coreboot.org/c/coreboot/+/34075/4/src/soc/nvidia/tegra210/mmu...
PS4, Line 26: uintptr_t start, end;
Does this mean uint64_t doesn't implicitly convert to uintptr_t on 64-bit architectures anymore? ... […]
It will still implicitly convert in general - this is only flagged because we use pointers in the function call, and unsigned long long* is not implicitly convertible to unsigned long*.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b52f37793151041b7bdee9ec3708bfad69617b2
Gerrit-Change-Number: 34075
Gerrit-PatchSet: 6
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jul 2019 20:14:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment