Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82273?usp=email )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Revert "mb/google/brox: Update verb table to fix headset detection" ......................................................................
Revert "mb/google/brox: Update verb table to fix headset detection"
This reverts commit f867c9c5473156617691d78350c362cd993bfcdd.
The new verb table breaks external mic detection on brox. Revert and use old verb tables instead.
BUG=b:330433089 BRANCH=main TEST=Verified headset on Brox When connected to audiojack in power_save state of legacy hda driver, headset is detected and audio is resumed.
Change-Id: I0d8c092de6166b2c62f5ecc3deaf4960128e6106 Signed-off-by: Terry Cheong htcheong@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/82273 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Shelley Chen shchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h index 482c0a6..c0b0eb0 100644 --- a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h +++ b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h @@ -110,9 +110,9 @@ * To set LDO1/LDO2 as default (used for headset) */ 0x02050008, - 0x0204EA0C, + 0x02046A0C, 0x02050008, - 0x0204EA0C, + 0x02046A0C, };
const u32 pc_beep_verbs[] = {