Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44905 )
Change subject: mb/google/puff: Convert ASL file to new DPTF dt impl ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 274: .thresholds={TEMP_PCT(90, 85), : TEMP_PCT(85, 75), : TEMP_PCT(75, 65), : TEMP_PCT(65, 55), : TEMP_PCT(55, 45),}}" This is slightly different than dptf.asl, should be: 90, 85 85, 75, 80, 65 75, 55 70, 45
note that there's an extra _AC5 in the dptf.asl which has a corresponding fan speed of 0
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 295: # 10-15W PL1 in 200mW increments, avg over 28-32s interval : # PL2 is fixed at 64W, avg over 28-32s interval These comments are not accurate; PL1 is fixed at 15W here, and PL2 can range from 25-64W