Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47309 )
Change subject: mb/google/zork: Add func to determine fingerprint gpio init ......................................................................
Patch Set 3: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/47309/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47309/3//COMMIT_MSG@10 PS3, Line 10: by the board. Probably add the detail that variant_has_fingerprint returns true even if fingerprint is present only on some SKUs of a variant. This is to ensure that fingerprint GPIOs are configured for that variant target without really encoding SKU information.
https://review.coreboot.org/c/coreboot/+/47309/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/variant.c:
https://review.coreboot.org/c/coreboot/+/47309/3/src/mainboard/google/zork/v... PS3, Line 9: (struct soc_amd_picasso_config *) I don't think this is required.
https://review.coreboot.org/c/coreboot/+/47309/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/variant.c:
https://review.coreboot.org/c/coreboot/+/47309/3/src/mainboard/google/zork/v... PS3, Line 9: (struct soc_amd_picasso_config *) same here.