[coreboot-gerrit] Change in coreboot[master]: mb/google/kukui: Fix no firmware beep issue

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )

Change subject: mb/google/kukui: Fix no firmware beep issue
......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/chromeos.c:

https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... 
PS9, Line 22: 	struct lb_gpio chromeos_gpios[] = {
            : 		{EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"},
            : 		{EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"},
            : 		{CR50_IRQ.id, ACTIVE_HIGH, -1, "TPM interrupt"},
            : #if !CONFIG(RT1015_I2C_MODE)
            : 		{GPIO_EN_SPK_AMP.id, ACTIVE_HIGH, -1, "speaker enable"},
            : #endif
            : 	};
            : 
            : 	lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
we can revise this better:

struct lb_gpio common_gpios[] = {
   ...
 };

struct lb_gpio speaker_gpios[] = {
 };

lb_add_gpios(gpios, common_gpios, ...);
 if (!CONFIG(RT1015_I2C_MODE))
    lb_add_gpios(gpios,speaker_gios, ...);

https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/47586/9/src/mainboard/google/kukui/... 
PS9, Line 98: 15
this should be in another patch.