build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34081 )
Change subject: device/oprom: Reduce indentation ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34081/1/src/device/oprom/yabel/io.c File src/device/oprom/yabel/io.c:
https://review.coreboot.org/c/coreboot/+/34081/1/src/device/oprom/yabel/io.c... PS1, Line 432: DEBUG_PRINTF_INTR("%s(): PCI Config Read from device: bus: %02x, devfn: %02x, offset: %02x\n", line over 96 characters
https://review.coreboot.org/c/coreboot/+/34081/1/src/device/oprom/yabel/io.c... PS1, Line 447: ("%s(): Config read access invalid device! bus: %02x (%02x), devfn: %02x (%02x), offs: %02x\n", line over 96 characters
https://review.coreboot.org/c/coreboot/+/34081/1/src/device/oprom/yabel/io.c... PS1, Line 453: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/34081/1/src/device/oprom/yabel/io.c... PS1, Line 455: switch (size) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/34081/1/src/device/oprom/yabel/io.c... PS1, Line 469: puid, size, Avoid multiple line dereference - prefer 'bios_device.puid'
https://review.coreboot.org/c/coreboot/+/34081/1/src/device/oprom/yabel/io.c... PS1, Line 512: switch (size) { switch and case should be at the same indent