Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31890 )
Change subject: mainboard/google/kahlee: Don't use AMD's secure OS ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31890/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31890/1//COMMIT_MSG@11 PS1, Line 11: chromium I haven't noticed this before.
https://review.coreboot.org/#/c/31890/1//COMMIT_MSG@12 PS1, Line 12: the updated AMDFWTool and a 0-byte secure OS If I understand your test, this statement seems a bit irrelevant. This patch ought to prevent there from being a SecureOS entry in the directory table, and the --secureos <0-byte filename> shouldn't be passed to amdfwtool.
Maybe rm -rf build/amdfw.rom && make V=1 * verify no --secureos argument
Or hexdump -C build/coreboot.rom | less Search with /20000\ \ aa Goto addr at offset 0x14 b[24:0] /f40000 (currently on mine) Should see $PSP cookie * verify no type=02 in the first column
https://review.coreboot.org/#/c/31890/1/src/mainboard/google/kahlee/Kconfig File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/#/c/31890/1/src/mainboard/google/kahlee/Kconfig@... PS1, Line 145: SCURE
Yes, this is what the variable is named. […]
I've been going back and forth over changing the name, however now's the time to do it if we're going to.
So since the name may propagate, I think I would like to change it. I'd still keep some sort of prefix on the symbol though; e.g. USE_, ADD_, etc.