View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 11: chromium

    I haven't noticed this before.

  • Patch Set #1, Line 12: the updated AMDFWTool and a 0-byte secure OS

    If I understand your test, this statement seems a bit irrelevant. This patch ought to prevent there from being a SecureOS entry in the directory table, and the --secureos <0-byte filename> shouldn't be passed to amdfwtool.

    Maybe rm -rf build/amdfw.rom && make V=1

    • verify no --secureos argument

    Or hexdump -C build/coreboot.rom | less Search with /20000\ \ aa Goto addr at offset 0x14 b[24:0] /f40000 (currently on mine) Should see $PSP cookie

    • verify no type=02 in the first column

• File src/mainboard/google/kahlee/Kconfig:

  • Patch Set #1, Line 145: SCURE

    Yes, this is what the variable is named. […]

    I've been going back and forth over changing the name, however now's the time to do it if we're going to.

    So since the name may propagate, I think I would like to change it. I'd still keep some sort of prefix on the symbol though; e.g. USE_, ADD_, etc.

To view, visit change 31890. To unsubscribe, or for help writing mail filters, visit settings.