Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44913 )
Change subject: soc/intel/tigerlake: Skip GPIO configuration from FSP
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44913/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44913/1//COMMIT_MSG@7
PS1, Line 7: Gpio
nit: GPIO
Done
https://review.coreboot.org/c/coreboot/+/44913/1//COMMIT_MSG@9
PS1, Line 9: v3333
Do you need to add Cq-Depend on chromium CL? Or is FSP already upreved to v3333+?
Chromium CL is not ready yet, will add it once there is a merge CL for v3333.
https://review.coreboot.org/c/coreboot/+/44913/1//COMMIT_MSG@10
PS1, Line 10: Coreboot
Verify that the word 'coreboot' is lowercase (lint-stable-021-coreboot-lowercase): 'coreboot' should […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32f35a188d510db8e4d8973cae78297d49a9240
Gerrit-Change-Number: 44913
Gerrit-PatchSet: 2
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Sep 2020 20:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment