EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )
Change subject: soc/intel/tigerlake: Support to initialize Memory
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Then we can combine the entry point in meminit_tgl. Currently only volteer is use TGL, right?
I think we should have entry points based on memory type. There are some differences in what each memory type supports or how it can be configured. Those entry points can do the work specific for that memory type and then call a common routine to do the stuff which is not different across different memories e.g. SPD setting.
But we have one baseboard for two different type. Deltan is SODIMM and Deltaur is solderdown. In this case we need use two different entry in romstage by type.
Oh won't be a problem, we use weak function for the entry. I am okay with this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47a5dcad3ee316871a6103b9d53ef7f6fc88d7d8
Gerrit-Change-Number: 39847
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Mar 2020 05:25:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment