Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45337 )
Change subject: soc/intel: Make use of common reset code block
......................................................................
Patch Set 12:
(3 comments)
Patch Set 12:
(3 comments)
I think there is something wrong with the latest patchset.
yeah, something happen while doing git add looks like
https://review.coreboot.org/c/coreboot/+/45337/11/src/drivers/intel/fsp2_0/K...
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/45337/11/src/drivers/intel/fsp2_0/K...
PS11, Line 219: use
used?
Ack
https://review.coreboot.org/c/coreboot/+/45337/11/src/drivers/intel/fsp2_0/K...
PS11, Line 256: correct global
correct status value for global reset type?
Ack
https://review.coreboot.org/c/coreboot/+/45337/11/src/soc/intel/common/basec...
File src/soc/intel/common/basecode/reset/reset.c:
PS11:
I don't think this file is needed anymore. Looks like a bad rebase? Also, all reset. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71531f4cf7a40efa9ec55c48c2cb4fb6ea90531f
Gerrit-Change-Number: 45337
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Sun, 20 Sep 2020 07:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment