Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74223 )
Change subject: vc/amd/fps/phoenix/platform_descriptors: drop logical-physical mapping ......................................................................
vc/amd/fps/phoenix/platform_descriptors: drop logical-physical mapping
Phoenix doesn't have different lane numbers in the schematic vs. in the descriptors, so remove that part from the comment on the fsp_dxio_descriptor struct. The start_logical_lane and end_logical_lane fields aren't renamed yet due to the patches updating the DXIO descriptors of the different mainboards still being in review and not being submitted into upstream yet. The fields will be renamed after those have been submitted.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I94664fd9d3807370b73f9fae8645d444e5faf7b7 --- M src/vendorcode/amd/fsp/phoenix/platform_descriptors.h 1 file changed, 21 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/74223/1
diff --git a/src/vendorcode/amd/fsp/phoenix/platform_descriptors.h b/src/vendorcode/amd/fsp/phoenix/platform_descriptors.h index a260138..8abfd3e 100644 --- a/src/vendorcode/amd/fsp/phoenix/platform_descriptors.h +++ b/src/vendorcode/amd/fsp/phoenix/platform_descriptors.h @@ -165,16 +165,10 @@
/* * Phoenix DXIO Descriptor: Used for assigning lanes to PCIe engines, configure - * bifurcation and other settings. Beware that the lane numbers in here are the - * logical and not the physical lane numbers! + * bifurcation and other settings. * - * Phoenix DXIO logical lane to physical PCIe lane mapping: - * - * logical | physical - * ----------|------------ - * PA[00:03] | GPP[03:00] - * PA[04:05] | GPP[08:09] - * PB[00:07] | GPP[12:19] + * TODO: Rename start_logical_lane and end_logical_lane to start_lane and end_lane when the + * updates of the mainboard's DXIO descriptors have been submitted. * * Different ports mustn't overlap or be assigned to the same lane(s). Within * ports with the same width the one with a higher start logical lane number