Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42833 )
Change subject: soc/amd/picasso/soc_util: add function to detect defeatured SKU ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42833/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42833/1//COMMIT_MSG@8 PS1, Line 8: nit: maybe mention what makes a SKU defeatured?
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 214: || Sanity check: Is this correct? Shouldn't this be an AND instead?