Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36126 )
Change subject: Documentation: Add cache as ram documentation ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... File Documentation/cpu/x86/car.md:
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... PS2, Line 23: Another thing about X86 platforms is that they generally : don't feature SRAM, static RAM.
"X86 platforms also generally don't provide static RAM, SRAM"? "Another thing" seems comparably coll […]
Done
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... PS2, Line 57: turned
turned out?
Done
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... PS2, Line 57: , like enumerated and have it's
to be enumerated and their?
Done
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... PS2, Line 105: sort of merged v2 and v3
implemented the ideas that worked well in v3 on top of v2
Done
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... PS2, Line 117: nd executed
I don't think the bootblock is executed before the main CPU is released from reset ;-)
Done
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... PS2, Line 120: Granted
I'd drop the work, the sentence still works.
Done
https://review.coreboot.org/c/coreboot/+/36126/2/Documentation/cpu/x86/car.m... PS2, Line 125: .
:
Done