Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64037 )
Change subject: mb/lenovo/{t440p,w541}/romstage: drop legacy IRQ routing ......................................................................
mb/lenovo/{t440p,w541}/romstage: drop legacy IRQ routing
Quoting Tristan Corrick:
"... DxxIR and DxxIP are only useful to support legacy interrupt routing. I'm not aware of a major, mainstream OS that uses legacy interrupt routing by default. It would be fine to leave these registers at their reset defaults. As far as I know, legacy interrupt routing should still work in that case, but the interrupts might not be balanced very well.
Lynx Point could benefit from making this config PCH-specific instead of board-specific, as was done in commit 33b535f15ded for earlier PCHs."
Untested.
Signed-off-by: Peter Lemenkov lemenkov@gmail.com Change-Id: I4abfcb5accdcf8acfc2aa8188b82494f173ff10c --- M src/mainboard/lenovo/t440p/romstage.c M src/mainboard/lenovo/w541/romstage.c 2 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/64037/1
diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c index 8a7da15..efdb66a 100644 --- a/src/mainboard/lenovo/t440p/romstage.c +++ b/src/mainboard/lenovo/t440p/romstage.c @@ -10,14 +10,6 @@
void mainboard_config_rcba(void) { - RCBA16(D31IR) = DIR_ROUTE(PIRQA, PIRQD, PIRQC, PIRQA); - RCBA16(D29IR) = DIR_ROUTE(PIRQH, PIRQD, PIRQA, PIRQC); - RCBA16(D28IR) = DIR_ROUTE(PIRQA, PIRQA, PIRQA, PIRQA); - RCBA16(D27IR) = DIR_ROUTE(PIRQG, PIRQB, PIRQC, PIRQD); - RCBA16(D26IR) = DIR_ROUTE(PIRQA, PIRQF, PIRQC, PIRQD); - RCBA16(D25IR) = DIR_ROUTE(PIRQE, PIRQF, PIRQG, PIRQH); - RCBA16(D22IR) = DIR_ROUTE(PIRQA, PIRQB, PIRQC, PIRQD); - RCBA16(D20IR) = DIR_ROUTE(PIRQA, PIRQB, PIRQC, PIRQD); }
void mb_late_romstage_setup(void) diff --git a/src/mainboard/lenovo/w541/romstage.c b/src/mainboard/lenovo/w541/romstage.c index 75b762a..d9cba06 100644 --- a/src/mainboard/lenovo/w541/romstage.c +++ b/src/mainboard/lenovo/w541/romstage.c @@ -10,14 +10,6 @@
void mainboard_config_rcba(void) { - RCBA16(D31IR) = DIR_ROUTE(PIRQA, PIRQD, PIRQC, PIRQA); - RCBA16(D29IR) = DIR_ROUTE(PIRQH, PIRQD, PIRQA, PIRQC); - RCBA16(D28IR) = DIR_ROUTE(PIRQA, PIRQA, PIRQA, PIRQA); - RCBA16(D27IR) = DIR_ROUTE(PIRQG, PIRQB, PIRQC, PIRQD); - RCBA16(D26IR) = DIR_ROUTE(PIRQA, PIRQF, PIRQC, PIRQD); - RCBA16(D25IR) = DIR_ROUTE(PIRQE, PIRQF, PIRQG, PIRQH); - RCBA16(D22IR) = DIR_ROUTE(PIRQA, PIRQB, PIRQC, PIRQD); - RCBA16(D20IR) = DIR_ROUTE(PIRQA, PIRQB, PIRQC, PIRQD); }
void mb_late_romstage_setup(void)