Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32223
Change subject: libpayload/drivers/timer: Use 64 bits to prevent overflow ......................................................................
libpayload/drivers/timer: Use 64 bits to prevent overflow
Cast cpu_khz to a 64 bit integer to prevent possible integer overflow (the multiplication is currently done using 32 bit math). Similar to 61dac13 (libpayload: timer: cast cpu_khz to make sure 64bit math is used).
Found-by: Coverity Scan, CID 1261177 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Iadb0abb7c7cc078f31a6d88d971f5d1b8ac62a9e --- M payloads/libpayload/drivers/timer/img_pistachio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/32223/1
diff --git a/payloads/libpayload/drivers/timer/img_pistachio.c b/payloads/libpayload/drivers/timer/img_pistachio.c index 070998f..d11c3ff 100644 --- a/payloads/libpayload/drivers/timer/img_pistachio.c +++ b/payloads/libpayload/drivers/timer/img_pistachio.c @@ -18,7 +18,7 @@
uint64_t timer_hz(void) { - return lib_sysinfo.cpu_khz * 1000; + return (uint64_t)lib_sysinfo.cpu_khz * 1000; }
uint64_t timer_raw_value(void)