Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36777 )
Change subject: cpu/x86/lapic: Support x86_64 and clean up code ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36777/7/src/include/cpu/x86/lapic.h File src/include/cpu/x86/lapic.h:
https://review.coreboot.org/c/coreboot/+/36777/7/src/include/cpu/x86/lapic.h... PS7, Line 11: return *((volatile uint32_t *)(LAPIC_DEFAULT_BASE + reg)); Why no t just use read32() ?