21 Oct
2020
21 Oct
'20
9:42 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44673 )
Change subject: cpu/intel/car/non-evict/cache_as_ram.S: Add support for longmode ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44673/6/src/cpu/intel/car/non-evict... File src/cpu/intel/car/non-evict/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/44673/6/src/cpu/intel/car/non-evict... PS6, Line 11: : #include <cpu/intel/car/cache_as_ram_symbols.inc> Is having this as an *.S file linked by included via the Makefile.inc a better idea?
--
To view, visit https://review.coreboot.org/c/coreboot/+/44673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e72a0bebf728fb678308006ea3a3aeb92910a84
Gerrit-Change-Number: 44673
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 09:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment