Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Martin Roth, Fred Reitberger.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 )
Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN ......................................................................
Patch Set 7:
(6 comments)
File src/mainboard/google/skyrim/port_descriptors.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/a1a8a3df_eacf08e4 PS7, Line 71: { /* DDI4 - Unused */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/3a354cfd_367d373b PS7, Line 71: { /* DDI4 - Unused */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/7f694f60_4deab88e PS7, Line 71: { /* DDI4 - Unused */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/dfe9ff9a_58846a3d PS7, Line 72: .connector_type = DDI_UNUSED_TYPE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/e6226485_72300032 PS7, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/b8ab6cc3_1244764b PS7, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no spaces at the start of a line