Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29895 )
Change subject: arch/x86/acpigen.c: Add a method to notify all CPU cores ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/29895/3/src/arch/x86/acpigen.c File src/arch/x86/acpigen.c:
https://review.coreboot.org/#/c/29895/3/src/arch/x86/acpigen.c@349 PS3, Line 349: unsigned hmmm?
https://review.coreboot.org/#/c/29895/3/src/arch/x86/acpigen.c@381 PS3, Line 381: core_id); Don't tell it would have fit a single line with `coreID` :-/
OTOH, once we got rid of all the static ASL code, there shouldn't be a need for CONFIG_ACPI_CPU_STRING anymore...