Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37594 )
Change subject: libpayload/drivers/i8042: Add AT translated Keyboard support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37594/4/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37594/4/payloads/libpayload/drivers... PS4, Line 332: /* Enable keyboard translated */ : if (!i8042_cmd(I8042_CMD_RD_CMD_BYTE)) { : int cmd = i8042_read_data_ps2(); : cmd |= I8042_CMD_BYTE_XLATE; : if (!i8042_cmd(I8042_CMD_WR_CMD_BYTE)) : i8042_write_data(cmd); : } maybe pull this into a separate function.
If the first i8042_cmd(I8042_CD_RD_CMD_BYTE) fails should it fall down the "set scancode set 1" path? Or at least print an error message...