31 Aug
2020
31 Aug
'20
12:57 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44796 )
Change subject: gma baytrail: Add power and clocks support ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... File common/valleyview/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... PS3, Line 69: return (Ref_Freq + Ref_Freq) / Int64 (Divider + 1);
Nit, I915 uses a div-round-closest, we probably should too (it's not […]
I'll check if we have a div-round-closest somewhere (I think so) and put it to use here
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/44796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I1e359882b78ed7436ec90f2ac8c4276f70eca1b0
Gerrit-Change-Number: 44796
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 30 Aug 2020 22:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment