Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: WIP: Add configurable ramstage support for minimal PCI scanning
......................................................................
Patch Set 14:
Here's another thought, how we could avoid trouble: Instead
of opting out of minimal-scanning per device, we could opt in.
For instance, if MINIMAL_PCI_SCANNING is enabled, use a
pci_dev_optional_read_resource() by default, and every driver
that supports it, could use it too, but would have to do so
explicitly.
I'm not sure. I think I'd rather have people indicate that they really need to be scanned, with the ..._always function. It will be a bit too easy for people to avoid the opt int.
But I'm not sure I know.
I think it boils down to the question if you want the author of a
patch that enables minial scanning or the reviewer to do the work:
* opt-in: Author has to look into each driver and decide if it can be enabled.
* opt-out: Reviewer gets to check every affected driver if it doesn't run into undefined behaviour.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2073d9f8e9297c2b02530821ebb634ea2a5c758e
Gerrit-Change-Number: 36221
Gerrit-PatchSet: 14
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Oct 2019 21:20:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment