Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 33: 1
Should this be 2?
No, this is the physical dies per package. So, it has to be 1. TGL MRC expects logical dies which is taken care of here: https://review.coreboot.org/c/coreboot/+/41612/14/util/spd_tools/intel/lp4x/...
channelsPerDie * ranksPerChannel * BitWidthPerChannel / 16 = 2 * 1 * 16 / 16 = 2
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 45: 2
Should this be 4?
Same as above: channelsPerDie * ranksPerChannel * BitWidthPerChannel / 16 = 2 * 2 * 16 / 16 = 4
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 112: }
Furquan, can you add the following (needed for Volta/Voxel)? […]
I already did that last night here: https://review.coreboot.org/c/coreboot/+/41989