Attention is currently required from: Johnny Lin, Angel Pons, Shuming Chu (Shuming).
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69198 )
Change subject: include/cper.h: Add CPER Memory Error Section definitions
......................................................................
Patch Set 2:
(1 comment)
File src/include/cper.h:
https://review.coreboot.org/c/coreboot/+/69198/comment/a131ad5d_290eaa3c
PS2, Line 508: /* UEFI Spec, Appendix N.2.5 Memory Error Types */
Let's add the spec version, table number, such as "IA32/X64 Processor Error Section (Table 255)"; also put it in the right sequence instead of end of the header file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a165350a16a4cbe4033a3e7c43fa23a5b27c44b
Gerrit-Change-Number: 69198
Gerrit-PatchSet: 2
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 19:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment