Attention is currently required from: Eran Mitrani, Kapil Porwal, Subrata Banik.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78318?usp=email )
Change subject: mb/google/rex/variant/rex0: HID over SPI - change frequency to 30MHZ
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/rex/variants/rex0/include/variant/acpi/hid_spi_elan.asl:
https://review.coreboot.org/c/coreboot/+/78318/comment/47431c3a_fa33c945 :
PS1, Line 35: 0x1C9C380, /* ConnectionSpeed (30MHz) */
i'd use a decimal instead of a hexadecimal number here, since that would make it more obvious that the value is 30MHz and not some magic number. maybe something for a follow-up patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If339f7a010fa51bf73b8898a55643b5e921d93b1
Gerrit-Change-Number: 78318
Gerrit-PatchSet: 1
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Fri, 13 Oct 2023 13:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment