Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43760 )
Change subject: mb/clevo/kbl-u: Add Clevo N240BU as variant ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43760/15/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/43760/15/src/mainboard/clevo/kbl-u/... PS15, Line 48: default 0x500000 if BOARD_CLEVO_N240BU
Starting with no configuration, selecting the variant, the 5 MB value is not chosen. […]
we will need sth like that: config CBFS_SIZE default 0x600000 if BOARD_CLEVO_N240BU && VBOOT default 0x500000 if BOARD_CLEVO_N240BU && !VBOOT ...
or this: if VBOOT config CBFS_SIZE default 0x500000 if BOARD_CLEVO_N240BU default 0x500000 if ... ... else config CBFS_SIZE default 0x500000 if BOARD_CLEVO_N240BU default 0x500000 if ... ... endif
I first want to make sure the cbfs sizes really differ, before making it that complex. I wouldn't be surprised if all kbl devices (or even all current clevo devices) have the same size.