Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33142 )
Change subject: Kconfig: Create coreboot separate stage kconfigs ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/33142/5/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/33142/5/src/Kconfig@141 PS5, Line 141: depends on !ARCH_X86 && (ENABLE_STAGE_ROMSTAGE || ENABLE_STAGE_VERSTAGE && VBOOT_STARTS_IN_ROMSTAGE) I assume this is supposed to mean !VBOOT_STARTS_IN_ROMSTAGE (or VBOOT_STARTS_IN_BOOTBLOCK, which is equivalent)? Not really necessary anyway, SEPARATE_VERSTAGE always implies STARTS_IN_BOOTBLOCK.
https://review.coreboot.org/#/c/33142/5/src/Kconfig@1200 PS5, Line 1200: bootblock architecture (example: arm, ppc, riscv, x86). This help text seems odd
https://review.coreboot.org/#/c/33142/5/src/Kconfig@1204 PS5, Line 1204: default y Shouldn't this depend on SEPARATE_VERSTAGE?
https://review.coreboot.org/#/c/33142/5/src/Kconfig@1218 PS5, Line 1218: default y Shouldn't this depend on POSTCAR_STAGE?