Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45078 )
Change subject: soc/intel/elkhartlake: Update Kconfig
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@11
PS4, Line 11: 2. remove HECI_DISABLE_USING_SMM config
Why?
Unlike chromeOS requirements, EHL does not officially support chromeOS and it supports full HECI functions by default.
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@17
PS4, Line 17: 8. update UART base address
I also prefer one commit for each of them so that each other is able to follow ;)
Thanks for your feedback, i understand your concern, but this is only 1 line change for each of them. So this is kept consistent with all Intel projects.
Don't worry, there are few more changes which includes more than one line change, I am planning to upstream them in individual patch :) Please help to review them later. Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a44d357d71be706f402a6b2a4f2d4e7c0eeb4a9
Gerrit-Change-Number: 45078
Gerrit-PatchSet: 5
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 27 Nov 2020 08:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-MessageType: comment