Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43484 )
Change subject: Documentation: Revise "24 hours wait period" rules ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43484/3/Documentation/getting_start... File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/43484/3/Documentation/getting_start... PS3, Line 59: from the same organization, although that's not a hard requirement.
Sorry, but I don't understand what you're getting at here, at all. […]
To be able to build stages of a board for different ARCH definetly needs some symmetry of headerfiles we place under arch/. If you don't want to call it design concept, call it communication and coordination between developers then.
Only reading CB:43310 commit message, did it appear as an emergency fix to you? It was not an existing regression in upstream even with CB:42226 merged. To me it very much appeared as a regular commit, needed to workaround the spinlock headers, to build with the single mentioned Kconfig enabled. AFAICS, that particular Kconfig does not have much relevance in upstream.
It was not until I saw your (PG) comment on the meeting minutes agenda, when I understood the fix was necessary for the downstream chromeos repository. After the merge Martin had commented "Yes, this was to fix a breakage that would have hit in chromeos". I thought he just meant builds with CHROMEOS=y, so he could have been more clear there about not being able to submit CB:42226 in downstream chromeos, if that was the case.
So my complaint here is really about the commit messages not answering the questions, which those with interest did not have a chance to ask. Having one outside reviewer for fast-tracking should help here.