Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35312 )
Change subject: soc/intel/skylake: Fix crash in MP init ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Add runtime detection of SGX and HT.
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG@12 PS1, Line 12: I could not find any relation between those two in any datasheet.
hmmm, with vendor firmware both can be active at the same time
likly a bug in coreboot or 3rdparty blobs
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG@14 PS1, Line 14: To fully migitate L1TF or E2E attacks, hyperthreading should be disabled
ah, well, sgx_enable only comes into effect when SOC_INTEL_COMMON_BLOCK_SGX=y, so SGX and HT are con […]
I guess this can be made runtime detectable, as not all CPUs have HT and SGX enabled.