Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44230 )
Change subject: cpu/x86: Introduce `CPU_X86_MTRR`
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44230/4/src/cpu/x86/Kconfig
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/44230/4/src/cpu/x86/Kconfig@11
PS4, Line 11: default n
maybe just 'default y if ARCH_X86' ? Only very old or weird CPU's have a different configurable cach […]
For now, I prefer to keep it default to n. It makes this patch easier to verify.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44230
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I743eaac99a85a5c712241ba48a320243c5a51f76
Gerrit-Change-Number: 44230
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 09 Aug 2020 08:03:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment