Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47584 )
Change subject: soc/amd: factor out vbnv_cmos_failed() into common block ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47584/2/src/soc/amd/common/block/vb... File src/soc/amd/common/block/vbnv_cmos/Kconfig:
https://review.coreboot.org/c/coreboot/+/47584/2/src/soc/amd/common/block/vb... PS2, Line 1: SOC_AMD_COMMON_BLOCK_VBNV_CMOS I think of common "block" as representing an IP block in the platform. VBNV is not really an IP block.
What do you think about: 1. Create a directory vboot/ under soc/amd/common which is included if CONFIG_SOC_AMD_COMMON is selected 2. Create a file vbnv.c under vboot/ which is included if CONFIG_VBOOT_VBNV_CMOS is selected.