[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33129/12/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

PS12:
> PCH terminology typically doesn't exist for atom line. idea behind PCH directory structure to make exclusive common code based on PCH alignment like SPT, CNP, CMP, ICP, TGP etc.

I don't believe it matters if some specific terminology is used or not. The IP block reuse is what matters. Moreover, monolithic dies in atom line are things of the past. There is inherently a pch in the past 2 parts on the atom line. But even if there wasn't -- the ip block reuse is the key bit and we should be organizing code in that manner.