26 Oct
2020
26 Oct
'20
9:41 p.m.
Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46669 )
Change subject: soc/amd/common/acpi: Create platform.asl to define acpi transitions ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... File src/soc/amd/common/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... PS2, Line 8: Scope(_SB){
Yes, it needs to be either _INI under _SB or _INI. […]
Done
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... PS2, Line 8: {
nit: space before {
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/46669
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8020173a15db1d310459d5c1de3600949b173b00
Gerrit-Change-Number: 46669
Gerrit-PatchSet: 5
Gerrit-Owner: Josie Nordrum josienordrum@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Oct 2020 20:41:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment