Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41155 )
Change subject: soc/intel/common/block/systemagent: Use TOUUD as base for MMIO above 4G ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41155/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/41155/2/src/soc/intel/common/block/... PS2, Line 56: enable_above_4GB_mmio
guess not as it's used in next patch.
Oh. And below. I clearly wasn't reading closely enough...
https://review.coreboot.org/c/coreboot/+/41155/2/src/soc/intel/common/block/... PS2, Line 118: if (!get_enable_above_4GB_mmio()) Why wouldn't we always report the usable address space above 4GiB? It seems odd to have this option. Subrata?