Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48898 )
Change subject: payloads/external: Update cbfs-ints with CONFIG_UPDATE_IMAGE
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48898/2/payloads/external/Makefile....
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48898/2/payloads/external/Makefile....
PS2, Line 108: $(if $(CONFIG_UPDATE_IMAGE),-$(CBFSTOOL) $< remove -n etc/ps2-keyboard-spinup 2>/dev/null)
If the CBFS-int file isn't present, wouldn't this cause a fatal error?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48898
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfbfff3ba680a85eb2f683867064b19f40b9d40f
Gerrit-Change-Number: 48898
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Jan 2021 16:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment