Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41876 )
Change subject: soc/intel/jasperlake: Generate LP4x SPD files using gen_spd.go ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41876/4/src/soc/intel/jasperlake/sp... File src/soc/intel/jasperlake/spd/lp4x/spd-1.hex:
https://review.coreboot.org/c/coreboot/+/41876/4/src/soc/intel/jasperlake/sp... PS4, Line 21: 00 00 00 00 00 00 00 : 00 00 00 00 00 00 00 00 00 00 00 00 00 These bytes(Module Part number) along with byte 325(Module serial number) are encoded as ASCII blanks (0x20) instead of ASCII NUL (0x0) in the SPDs shared by Intel.
MRC does not expect these bytes as per the advisory. But double-checking if we need to encode them as blanks.