build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27038 )
Change subject: Revert "sb/intel/{bd82x6,ibexpeak}: Move RCBA macros to a common location" ......................................................................
Patch Set 1:
(32 comments)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h File src/southbridge/intel/bd82x6x/pch.h:
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 273: #define RCBA8(x) *((volatile u8 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 274: #define RCBA16(x) *((volatile u16 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 275: #define RCBA32(x) *((volatile u32 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 277: #define RCBA_AND_OR(bits, x, and, or) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 278: RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or)) code indent should use tabs where possible
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 278: RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 324: #define RPFN_FNGET(reg,port) (((reg) >> ((port) * 4)) & 7) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 326: #define RPFN_FNSET(port,func) (((func) & 7) << ((port) * 4)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 413: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 413: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 413: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 413: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 413: #define DIR_ROUTE(x,a,b,c,d) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 414: RCBA16(x) = (((d) << DIR_IDR) | ((c) << DIR_ICR) | \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 415: ((b) << DIR_IBR) | ((a) << DIR_IAR)) code indent should use tabs where possible
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@... PS1, Line 415: ((b) << DIR_IBR) | ((a) << DIR_IAR)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h File src/southbridge/intel/ibexpeak/pch.h:
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 245: #define RCBA8(x) *((volatile u8 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 246: #define RCBA16(x) *((volatile u16 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 247: #define RCBA32(x) *((volatile u32 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 249: #define RCBA_AND_OR(bits, x, and, or) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 250: RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or)) code indent should use tabs where possible
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 250: RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 296: #define RPFN_FNGET(reg,port) (((reg) >> ((port) * 4)) & 7) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 298: #define RPFN_FNSET(port,func) (((func) & 7) << ((port) * 4)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 386: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 386: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 386: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 386: #define DIR_ROUTE(x,a,b,c,d) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 386: #define DIR_ROUTE(x,a,b,c,d) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 387: RCBA32(x) = (((d) << DIR_IDR) | ((c) << DIR_ICR) | \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 388: ((b) << DIR_IBR) | ((a) << DIR_IAR)) code indent should use tabs where possible
https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h... PS1, Line 388: ((b) << DIR_IBR) | ((a) << DIR_IAR)) please, no spaces at the start of a line