HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34092 )
Change subject: ec/lenovo/pmh7: Fix error conversion from 'int' to 'signed char:1'
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34092/6/src/ec/lenovo/pmh7/chip.h
File src/ec/lenovo/pmh7/chip.h:
https://review.coreboot.org/c/coreboot/+/34092/6/src/ec/lenovo/pmh7/chip.h@2...
PS6, Line 21: signed char dock_event_enable:1;
The signed single-bit bit field doesn't make sense to me, as the possible values are 0 or -1. […]
not sure, but I think 'devicetree.c' will not like it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34092
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6c5a424ff49a2df586432e1390d5a30166d6c6a
Gerrit-Change-Number: 34092
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: James
jye836@gmail.com
Gerrit-Comment-Date: Mon, 30 Dec 2019 09:25:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: James
jye836@gmail.com
Gerrit-MessageType: comment