Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/...
PS1, Line 25: select SYSTEM_TYPE_LAPTOP
It might be worth gating this too.
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/...
PS1, Line 140: VBOOT_LID_SWITCH
This probably should be gated by BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33
Gerrit-Change-Number: 40252
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrew McRae
amcrae@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Tue, 07 Apr 2020 03:09:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment