Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34120 )
Change subject: soc/intel/{cannonlake,icelake}: Do not define PCH_DEV_PMC in ramstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34120/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34120/2//COMMIT_MSG@10
PS2, Line 10: This device gets hidden from PCI bus
: in FSP-S
Uh... I found CB:22556 […]
What's the CL you were meaning? 22556 points to an em100 change. If devices are disappearing one needs to hang the fixed resources off of something. There's no 'platform device' that just floats currently, but we could add something like that. In either case, the resources need to be accounted for so the allocator will work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f69470ec80c7127a2b604ed2b1f794f5a63e126
Gerrit-Change-Number: 34120
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 09 Jul 2019 01:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment