Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40522 )
Change subject: drivers/ipmi: Read all FRU data fields for Product, Board and Chassis Info ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40522/5/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40522/5/src/drivers/ipmi/ipmi_fru.c... PS5, Line 516: struct fru_chassis_info chassis_info = fru_info_str->chassis_info;
prod_info, board_info and chassis_info are structs not pointers.
Done
https://review.coreboot.org/c/coreboot/+/40522/5/src/drivers/ipmi/ipmi_ops.h File src/drivers/ipmi/ipmi_ops.h:
https://review.coreboot.org/c/coreboot/+/40522/5/src/drivers/ipmi/ipmi_ops.h... PS5, Line 115: int custom_count; /* Number of custom fields */
Do you mean the order of the members in the struct? I think the order and the memory space should be […]
Done