Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v...
PS4, Line 6: bin
Forgot to include the patch: CB:44999
Because i think the last revert CL https://review.coreboot.org/44999 already be merged, So i repo sync first, then go build the two tools, Rerun gen_part_iid then update to the CL patch 4. Is it incorrect?
Should i use git chectout to rebase to the CL https://review.coreboot.org/44999 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd
Gerrit-Change-Number: 45810
Gerrit-PatchSet: 4
Gerrit-Owner: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Vincent Wang
vwang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Teresa Tseng
teresa_tseng@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Oct 2020 07:20:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment