Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... PS10, Line 237: * Send PMC IPC command
Can you please add comments providing more details about the params and the return value?
will include in the refactoring of this method
https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... PS10, Line 34:
Please be consistent about use of tabs and spaces.
Done
https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... PS10, Line 602: int
Since you are using coreboot error codes, why not use cb_err_t?
Done
https://review.coreboot.org/c/coreboot/+/37871/10/src/soc/intel/common/block... PS10, Line 607: PMC_IPC_XFER_TIMEOUT_MS
How was this timeout decided? Is this documented anywhere?
Looking for information on this...I know there was a document used for this timeout just tracking it down can only locate the max timeout (3 seconds)