Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35005 )
Change subject: mb/google/hatch: Add settings for noise mitgation
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35005/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35005/1/src/mainboard/google/hatch/...
PS1, Line 196: # VR Slew rate setting
: register "AcousticNoiseMitigation" = "1"
: register "SlowSlewRateForIa" = "2"
: register "SlowSlewRateForGt" = "2"
: register "SlowSlewRateForSa" = "2"
: register "FastPkgCRampDisableIa" = "1"
: register "FastPkgCRampDisableGt" = "1"
: register "FastPkgCRampDisableSa" = "1"
I believe these are currently required only for hatch variant. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49e834825b3f1e5bf02f9523d7caa93b544c9d17
Gerrit-Change-Number: 35005
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 20 Aug 2019 06:21:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment