Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35383 )
Change subject: drivers/intel/fsp2_0: Allow platform to increase mem overhead
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35383/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35383/1//COMMIT_MSG@13
PS1, Line 13: AMD TSEG
Thanks for the thought on stuffing TSEG into cbmem. […]
Just a reminder; cbmem_top_init_once() calls quick_ram_check() which requires rw-access to u32 immediate below cbmem_top(). That might fail if TSEG is locked (after soft reset or on S3 resume), I remember seeing clear_tvalid() implementation in picasso/memmap.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia291273b9b7fda0e34be7879473eabd7b53b47b4
Gerrit-Change-Number: 35383
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 13 Sep 2019 02:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment