1 Feb
2019
1 Feb
'19
11:24 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31206 )
Change subject: Kconfig: Add system type entries for common enclosures ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31206/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/31206/3/src/Kconfig@335 PS3, Line 335: default n Shouldn't this be
default y depends on !(SYSTEM_TYPE_LAPTOP || SYSTEM_TYPE_TABLET || SYSTEM_TYPE_DETACHABLE)
because otherwise no board is selecting it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31206
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148ec2329a1dd38ad55c60ba277a514c66376fcc
Gerrit-Change-Number: 31206
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt Delco delco@chromium.org
Gerrit-Comment-Date: Fri, 01 Feb 2019 23:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment