Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38586 )
Change subject: superio/aspeed/ast2400: Add eSPI auto detection ......................................................................
Patch Set 4:
(3 comments)
Tested how?
https://review.coreboot.org/c/coreboot/+/38586/4/src/superio/aspeed/ast2400/... File src/superio/aspeed/ast2400/superio.c:
https://review.coreboot.org/c/coreboot/+/38586/4/src/superio/aspeed/ast2400/... PS4, Line 110: // Detect eSPI Mode automatically C89 style for consistency?
https://review.coreboot.org/c/coreboot/+/38586/4/src/superio/aspeed/ast2400/... PS4, Line 113: 0x0F 0x0f
https://review.coreboot.org/c/coreboot/+/38586/4/src/superio/aspeed/ast2400/... PS4, Line 116: 0x0C 1. 0x0c 2. Add a macro for that value?