Attention is currently required from: Paul Menzel, Kyösti Mälkki.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74389 )
Change subject: src/arch/x86 Add CPU frequency APIs ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74389/comment/994d36ac_6eef6b9a PS1, Line 7: src/arch/x86
Please add a colon after the prefix.
Ack
https://review.coreboot.org/c/coreboot/+/74389/comment/6dced30d_9ee26597 PS1, Line 7: src/
Remove.
Ack
https://review.coreboot.org/c/coreboot/+/74389/comment/6668c32a_11da652b PS1, Line 8:
Please elaborate, what that API is needed for.
CPU frequency information is required to differentiate CPU SKU within in same CPU ids(Same CPU stepping). This will be used in early Coreboot log with CPU id info.
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/74389/comment/a57854a9_e87a6f3f PS1, Line 6: #include <intelblocks/msr.h>
No intel specific includes under arch/. […]
it's common at least recent intel CPU. Let me check if I can add other header file. or Do you have any recommend header file to add these intel APIs?